Add nos17:creator-pack-02
#52
Conversation
|
The files installed correctly via command line. Tested in game. |
|
Please take a look at the |
|
🤦♂️ |
| - assetId: "dk1-bowling-lanes" | ||
| include: | ||
| - "\\.SC4Model$" | ||
| - assetId: "dk1-burger-chef" | ||
| include: | ||
| - "\\.SC4Model$" | ||
| - assetId: "dk1-convenience-stores-1" | ||
| include: | ||
| - "\\.SC4Model$" | ||
| - assetId: "dk1-convenience-stores-2" | ||
| include: | ||
| - "\\.SC4Model$" | ||
| - assetId: "dk1-donut-shops" | ||
| include: | ||
| - "\\.SC4Model$" | ||
| - assetId: "dk1-king-and-queen" | ||
| include: | ||
| - "\\.SC4Model$" | ||
| - assetId: "dk1-retro-kroger" | ||
| include: | ||
| - "\\.SC4Model$" | ||
| - assetId: "dk1-small-restaurants" | ||
| include: | ||
| - "\\.SC4Model$" | ||
|
|
There was a problem hiding this comment.
Including files directly from foreign assets isn't what I'd usually do (see #40).
Would it be acceptable for you to add the dk1 packages as dependencies instead? This would imply that the dk1 lots gets installed, too, when your creator pack package is installed.
The alternative would be to split off the models from the dk1 packages into separate packages, so you only depend on the models without the lots.
There was a problem hiding this comment.
Including files directly from foreign assets isn't what I'd usually do (see #40).
Would it be acceptable for you to add the dk1 packages as dependencies instead? This would imply that the dk1 lots gets installed, too, when your creator pack package is installed.
The alternative would be to split off the models from the dk1 packages into separate packages, so you only depend on the models without the lots.
Sure thing. I originally was not excited to make the models separate packages, but it's probably the best route to take now.
There was a problem hiding this comment.
Which of the two approaches do you prefer? Do you plan to implement it? Otherwise, I'll try to make the changes.
There was a problem hiding this comment.
Which of the two approaches do you prefer? Do you plan to implement it? Otherwise, I'll try to make the changes.
Sorry I wasn't clear. The second options. Not a huge fan of including them as dependencies as that would also install dk1's lots which I do not want to include. I will remake them as model/dependency packages, probably sometime within the next week or so.
No description provided.