[Bugfix] JS-SDK: Remove dotenv and add tests #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelsideguide
approved these changes
Apr 25, 2024
|
|
All good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I might be misunderstanding something here, but I suspect that using 'dotenv' in an NPM module could result in some unexpected modification of the users environment variables. For example, upon importing FirecrawlApp, I would be surprised if it loaded my .env file into the environment. I think this should be a decision left to the end-user.
I also added tests after removing dotenv, but it's in a second commit, so feel free to ignore and cherry pick a7be09e if you don't want the jest tests.