Update docs.md: Add note on mender_machine_type breaking the build #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog: Improve MENDER_MACHINE_TYPE documentation Signed-off-by: Simon A. Eugster <[email protected]>
|
Merging these commits will result in the following changelog entries: Changelogsmender-docs (patch-3)New changes in mender-docs since hosted:
|
kacf
reviewed
Feb 29, 2024
| @@ -188,6 +188,10 @@ variable is only relevant when building a complete partitioned image (any suffix | |||
| ending in `img`). Once flashed with this image, the device type will persist | |||
| across subsequent updates. | |||
|
|
|||
| Note that changing the `MENDER_DEVICE_TYPE` requires changing the `IMAGE_NAME` | |||
| and `IMAGE_LINK_NAME` when generating the initramfs fails; see | |||
| [this GitHub issue](https://github.com/OE4T/tegra-demo-distro/discussions/95#discussioncomment-687382). | |||
There was a problem hiding this comment.
Thanks for the info! However, I think this belongs in the troubleshooting section, not in the variable description.
I haven't looked deeply at this problem, but isn't it really kernel.bbclass which should fixed to refer to IMAGE_NAME and IMAGE_LINK_NAME properly, instead of relying on them to be set to specific values? Otherwise they are kind of pointless, if they can't be set to anything besides the default. I guess it's independent from this doc fix though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External Contributor Checklist
🚨 Please review the guidelines for contributing to this repository.
The majority of our contributions are fixes, which means your commit should have
the form below:
git --signoff. Also note that the signoff author must match the author of the commit.Description
See title.