Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(installation): Add post install instructions for NATS replication #2455

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alfrunes
Copy link
Contributor

@alfrunes alfrunes commented Sep 9, 2024

No description provided.

Copy link
Contributor

@merlin-northern merlin-northern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok dropped two comments

!!!! Please replace `NATS_URL` in the following snippet with a URL that resolves to any of the NATS pods.

```bash
NATS_URL="nats://mender-nats" # REPLACE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NATS_URL="nats://mender-nats" # REPLACE
NATS_URL="nats://mender-nats" # set to your own nats URL


```bash
NATS_URL="nats://mender-nats" # REPLACE
kubectl run --env=NATS_URL=$NATS_URL --image=natsio/nats-box:0.14.5-nonroot \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kubectl run --env=NATS_URL=$NATS_URL --image=natsio/nats-box:0.14.5-nonroot \
kubectl run --env=NATS_URL='$NATS_URL" --image=natsio/nats-box:0.14.5-nonroot \

Copy link
Contributor

@TheMeaningfulEngineer TheMeaningfulEngineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested this, but it was a suggestion on multiple live calls already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants