Explicit error for compressed Artifacts #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielskinstad
force-pushed
the
compression-error
branch
from
a0fed4f
to
7b5d156
Compare
vpodzime
reviewed
Sep 30, 2024
| @@ -204,6 +221,12 @@ mender_artifact_process_data(mender_artifact_ctx_t *ctx, | |||
| /* Parse data */ | |||
| do { | |||
|
|
|||
| /* We do not support compressed artifacts */ | |||
| if (is_compressed(ctx->file.name)) { | |||
There was a problem hiding this comment.
Is this derived from the URL?
There was a problem hiding this comment.
The file name? That comes from the payload
Ticket: MEN-7528 Signed-off-by: Daniel Skinstad Drabitzius <[email protected]>
Avoids division by zero errors if you're e.g. using a really small dummy artifact Ticket: None Signed-off-by: Daniel Skinstad Drabitzius <[email protected]>
danielskinstad
force-pushed
the
compression-error
branch
from
7b5d156
to
1f0ef87
Compare
lluiscampos
approved these changes
Sep 30, 2024
| if (((index * 10) / size) > download_progress) { | ||
| download_progress = (index * 10) / size; | ||
| mender_log_info("Downloading '%s' %zu0%%... [%zu/%zu]", type, download_progress, index, size); | ||
| if (size > 0) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.