Extrapolate an interface for reading Zephyr nvs data.

[pasinskim]

In many place we are reading the length of the data, allocating memory, and then using allocated memory to read the actual data. Instead of repeating it in many places we can use an interface to deal with it and use when we need to access nvs stored data.

[danielskinstad]

fyi: To get the pipeline to pass, you can do something hacky like this: docker run -v path/to/mender-mcu:/mender-mcu -it ubuntu:20.04 and format your files with the clang-format in the container

[lluiscampos]

fyi: To get the pipeline to pass, you can do something hacky like this: docker run -v path/to/mender-mcu:/mender-mcu -it ubuntu:20.04 and format your files with the clang-format in the container

The OS project is going to accept my contribution (see joelguittet/mender-mcu-client#67) so I launched a similar one for our fork (see #10) with the intention of avoiding exactly that sort of hacky formatting 😅

[vpodzime]

Nice! 👏

[pasinskim]

@danielskinstad @lluiscampos this is pretty weird. I run the clang-format locally and everything passes. Need to figure out how to run it locally exact same way as it is done in the CI.

[danielskinstad]

@danielskinstad @lluiscampos this is pretty weird. I run the clang-format locally and everything passes. Need to figure out how to run it locally exact same way as it is done in the CI.

I have this version

daniel@daniel-thinkpad:~/.../repos/mender-mcu$ clang-format --version
clang-format version 18.1.8

and use this script, which seems to work:

for source_file in `git ls-tree -r HEAD --name-only | grep -E '(.*\.c$|.*\.h$|.*\.cpp$|.*\.hpp$)' | grep -vFf .clang-format-ignore`
do
    lines=$(clang-format -i ${source_file} 2>&1 | wc -l)
done

[pasinskim]

@danielskinstad for testing can you run your clang-format on my latest commit and see which places it complains about? Thanks.

[danielskinstad]

@danielskinstad for testing can you run your clang-format on my latest commit and see which places it complains about? Thanks.

Hmm, it is as you said: it passes locally. I even tried the clang-format from ubuntu:24.04 locally, and that also passed. Weird, tried running it manually from gitlab aswell, still fails.

EDIT:

I checked the wrong thing, I assumed it was ./.github/workflows/check_code_format.sh that failed, but it's ./.github/workflows/check_equivalence_tests.sh. This fails locally.

[mender-test-bot]

Merging these commits will result in the following changelog entries:

Changelogs

mender-mcu (main)

New changes in mender-mcu since main:

• Extrapolate an interface for reading Zephyr nvs data.
  (MEN-7380)

[pasinskim]

@danielskinstad thanks! I spend way too much time trying to figure out what is wrong with formatting and completely missed check_equivalence_tests.sh.

[danielskinstad]

Just fyi, if there is no change in functionality for the user, you don't need to include changelog. Usually used when it's a fix or a feat.
https://github.com/mendersoftware/mendertesting/blob/master/commitlint/grammar.md