Skip to content

Commit

Permalink
chore: aligned auditlog sorting indication with rest of the UI
Browse files Browse the repository at this point in the history
Signed-off-by: Manuel Zedel <[email protected]>
  • Loading branch information
mzedel committed Sep 2, 2024
1 parent 8d619a5 commit 1813394
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -361,36 +361,31 @@ exports[`Auditlogs Component renders correctly 1`] = `
>
<div
class="columnHeader"
style="cursor: initial;"
>
Performed by
</div>
<div
class="columnHeader"
style="cursor: initial;"
>
Action
</div>
<div
class="columnHeader"
style="cursor: initial;"
>
Type
</div>
<div
class="columnHeader"
style="cursor: initial;"
>
Changed
</div>
<div
class="columnHeader"
style="cursor: initial;"
>
More details
</div>
<div
class="columnHeader"
class="columnHeader sortable"
>
Time
<svg
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,36 +10,31 @@ exports[`Auditlogs Component renders correctly 1`] = `
>
<div
class="columnHeader"
style="cursor: initial;"
>
Performed by
</div>
<div
class="columnHeader"
style="cursor: initial;"
>
Action
</div>
<div
class="columnHeader"
style="cursor: initial;"
>
Type
</div>
<div
class="columnHeader"
style="cursor: initial;"
>
Changed
</div>
<div
class="columnHeader"
style="cursor: initial;"
>
More details
</div>
<div
class="columnHeader"
class="columnHeader sortable"
>
Time
<svg
Expand Down
3 changes: 1 addition & 2 deletions frontend/src/js/components/auditlogs/auditlogslist.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,9 @@ export const AuditLogsList = ({
<div className="auditlogs-list-item auditlogs-list-item-header muted">
{auditLogColumns.map((column, index) => (
<div
className="columnHeader"
className={`columnHeader${column.sortable ? ' sortable' : ''}`}
key={`columnHeader-${index}`}
onClick={() => (column.sortable ? onChangeSorting() : null)}
style={column.sortable ? {} : { cursor: 'initial' }}
>
{column.title}
{column.sortable && <SortIcon columnKey="time" sortDown={sort.direction === SORTING_OPTIONS.desc} />}
Expand Down

0 comments on commit 1813394

Please sign in to comment.