Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: monorepo support for helm version bump #339

Conversation

oldgiova
Copy link
Contributor

@oldgiova oldgiova commented Sep 27, 2024

The Helm Version Bump is accepting multiple keys to update the tags.

Ticket: QA-760

  • Add support for monorepo (from single CONTAINER to multiple CONTAINERS input)
  • Add DRY_RUN feature
  • not changing the repository key: the one in the values-[staging|prod].yaml will apply

@oldgiova oldgiova force-pushed the QA-760-mender-helm-version-bump-monorepo branch 2 times, most recently from 880ec86 to 70fb5e1 Compare September 27, 2024 14:55
The Helm Version Bump is accepting multiple keys to update the tags.

Ticket: QA-760

Signed-off-by: Roberto Giovanardi <[email protected]>
@oldgiova oldgiova force-pushed the QA-760-mender-helm-version-bump-monorepo branch from 70fb5e1 to b8afbd9 Compare September 27, 2024 16:20
@oldgiova oldgiova changed the title 🚧 ci: monorepo support for helm version bump ci: monorepo support for helm version bump Sep 27, 2024
Copy link
Contributor

@alfrunes alfrunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please move this to the monorepo?
By proceeding to use mendertesting as a template repository we will continue to break maintenance branches.

@mzedel
Copy link
Contributor

mzedel commented Sep 30, 2024

Can we please move this to the monorepo?
By proceeding to use mendertesting as a template repository we will continue to break maintenance branches.

The monorepo doesn't exist in isolation though and e.g. the bump is getting used in other repos. Should we instead maybe version the templates and treat them as regular dependencies to limit the breakage?

@oldgiova
Copy link
Contributor Author

Can we please move this to the monorepo?
By proceeding to use mendertesting as a template repository we will continue to break maintenance branches.

The helm version bump CI code is used by alvaldi-helm and mender-helm only. By moving it to monorepo, we should move also mender-helm to monorepo (something that we could do, actually, but we chosen not to do at the release-split start), and we need to include it from alvaldi-helm

The monorepo doesn't exist in isolation though and e.g. the bump is getting used in other repos. Should we instead maybe version the templates and treat them as regular dependencies to limit the breakage?

I like the idea of versioning it. You mean to create a new tag for the mendertesting repo?, for example:

  - project: 'Northern.tech/Mender/mendertesting'
    file: '.gitlab-ci-check-helm-version-bump.yml'
    ref: v1.0.1

Or you mean to just rename the job to helm-version-bump_v1:, helm-version-bump_v2: and so on?

@alfrunes
Copy link
Contributor

Sorry, I was confused while reading the PR. I mistakenly thought these were templates imported by the mender-server project and was just a little paranoid to not repeat the same mistake we did before.

@oldgiova oldgiova merged commit 3521b3a into mendersoftware:master Oct 2, 2024
1 check passed
@oldgiova oldgiova deleted the QA-760-mender-helm-version-bump-monorepo branch October 2, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants