Sitewide Search #71
Sitewide Search #71
Conversation
| @@ -7,6 +7,6 @@ | |||
There was a problem hiding this comment.
@geihsler could I ask the reason why do you decide to move it into shared?
There was a problem hiding this comment.
Well, I moved it to shared since it's being used by two different controllers. I wasn't sure if it was idiomatic to have the SearchController reach into the Articles views and use them, but I'm happy to move the articles partials back to their original location.
There was a problem hiding this comment.
I'm not sure view should depend on what controllers that call to render the view. Because what I think Rails follow convention to has a partial of an object in collection view itself, and that's why in Rails introduces a shortcut to render collection by just call render @articles. @jordanbyron, what do you think?
There was a problem hiding this comment.
@geihsler @samnang I think it's OK to reach into article views for article specific partials. The shared folder really exists for partials which don't have a home and are truly "shared" with every page like the footer and navigation sections.
Oh a related note, I don't know if displaying the full article partial in the search results is the best option. Especially when we start to display articles, people, and activities. However for right now just use the articles partial until we start pulling in more records into the search page.
|
Ok, I think I'm done messing around with the search box styling. Please take a look as I believe a very rudimentary search for articles is fully working. I also move the partials back to their original location. Future improvements:
Anything else? I just want to caveat all of this work by saying that I have don't much rails (or web) work, so I'm very open to areas of improvement. Thanks! |
@jordanbyron The whole issue #12 sitewide search feature is not yet complete. I haven't implemented the front-end styling yet, but I wanted you to take a look to make sure that it looks ok from the controller down to the db.
I waffled over whether to just shove a search method in the
ArticlesControlleror make a newSearchController. I went with the latter, which forced me to move a few partials fromviews/articlesintoviews/shared.Anyway, I just wanted to give you a sneak peek while I worked on the UI bits. I look forward to the feedback!