Skip to content
This repository has been archived by the owner on Dec 21, 2022. It is now read-only.

[WC-887][WC-383][WC-778] Update Widget Generator templates #1196

Merged
merged 4 commits into from
Jan 4, 2022
Merged

[WC-887][WC-383][WC-778] Update Widget Generator templates #1196

merged 4 commits into from
Jan 4, 2022

Conversation

diego-antonelli
Copy link
Contributor

@diego-antonelli diego-antonelli commented Jan 3, 2022 •
edited
Loading

Checklist

  • Contains unit tests ✅
  • Contains breaking changes ❌
  • Contains Atlas changes ❌
  • Compatible with: MX 9️⃣

This PR contains

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Other (describe)

What is the purpose of this PR?

Update widget generator templates with latest libraries and configurations following the mono repo. Its also being added a editorConfig files during the widget generation with examples for getProperties and check functions.

Relevant changes

  • Updated libraries
  • Updated templates
  • Fix prettier inconsistencies

What should be covered while testing?

General usage of widget generator and final generated files.

@diego-antonelli diego-antonelli added enhancement New feature or request Cross-Platform Web & Native labels Jan 3, 2022
@diego-antonelli diego-antonelli requested a review from a team January 3, 2022 16:31
@diego-antonelli diego-antonelli requested a review from a team as a code owner January 3, 2022 16:31
@diego-antonelli diego-antonelli changed the title [WC-887] Update Widget Generator templates [WC-887][WC-383][WC-778] Update Widget Generator templates Jan 3, 2022
raffiar
raffiar reviewed Jan 4, 2022
View reviewed changes
Copy link
Contributor

@raffiar raffiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find any blocker at this point, the only thing which is strange and can cause pain later is a new way of loading yeoman actions, but if it's the only way to do it then we can merge it like this

@diego-antonelli diego-antonelli merged commit 02e30fb into master Jan 4, 2022
@diego-antonelli diego-antonelli deleted the feat/update-generator-templates branch January 4, 2022 17:18
Ahmad-Elsayed pushed a commit that referenced this pull request Jan 5, 2022
@diego-antonelli
Merge pull request #1196 from mendix/feat/update-generator-templates
5cb7cdb 
[WC-887][WC-383][WC-778] Update Widget Generator templates
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leonardomendix leonardomendix leonardomendix approved these changes

@raffiar raffiar raffiar approved these changes

Assignees
No one assigned
Labels
Cross-Platform Web & Native enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diego-antonelli @raffiar @leonardomendix