Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CoroutineAction #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement CoroutineAction #36

wants to merge 2 commits into from

Conversation

jarkonik
Copy link

I've implemented Unity-like coroutines(but without Unity dependency) that can be used as actions

@meniku
Copy link
Owner

meniku commented Apr 29, 2021

Hi @jarkonik that looks very useful, thanks. I'm gonna test it within the next days or so


protected override void DoStop()
{
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried your implemetation in my game. When another node tried to stop the CoroutineAction node, it didn't stop immediately. It seems like you didn't take this case into consideration. So the DoStop method should be rewritten like this:

protected override void DoStop()
{
    Clock.RemoveTimer(Progress);
    Stopped(false);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants