-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Added specified error toasts, and improved button states #182
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0cb5dfa
to
d7ecb94
Compare
d7ecb94
to
14fcbc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed testing steps, can confirm toasts appear as expected
Spoke to @Andrew718PLTS offline, there's a few weird ux behaviours which we'll fix:
|
14fcbc1
to
ed450a0
Compare
@nvtaveras Issues are fixed and tested on test deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found another issue. There is a race condition if you enter your swapIn amount too early.
Reproduce:
- Do a full page reload on the deployed preview app
- Paste a number into the swapIn field as quickly as you can
- See that the submit button turns red and says "Balance still loading"
- This message remains even when the balance has been loaded

@chapati23 Thank you, it's a known issue that will be fixed in the scope of this ticket. |
@chapati23 Fixed here in the third commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as just discussed on our call, there's another flaky issue that I found
to reproduce you have to be fast :)
- Copy a number that's higher than your current CELO balance into your clipboard
- Navigate to the swap page
- Position your cursor above the submit button
- Do a full page reload of the swap page and paste your high number from your clipboard into the
from
input as fast as you can - Now hammer the submit button as quickly as you can
- If you're fast enough, you are able to bypass all warnings and trigger a swap TX for an amount that's higher than what's actually in your wallet
cc0999a
to
9b5baec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, tried a bunch of scenarios on the preview deployment and couldn't reproduce any of the issues
Description
Other changes
Added truncated amount and tooltip when the amount is more than 8 digits.

Tested
Related issues
Checklist before requesting a review