update return url to object public url (#70)

meofiscoding · Nov 26, 2023 · a825f5d · a825f5d
1 parent 29e0b35
commit a825f5d
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/SimpleServer/src/Services/Crawler/CrawlData/Helper/GCSHelper.cs b/SimpleServer/src/Services/Crawler/CrawlData/Helper/GCSHelper.cs
@@ -11,8 +11,8 @@ public static class GCSHelper
         public static string UploadFile(string filePath, string objectName)
         {
             // set google credential
-            GoogleCredential credential = GoogleCredential.FromFile(Environment.GetEnvironmentVariable("GOOGLE_APPLICATION_CREDENTIALS"));
-            var storage = StorageClient.Create(credential);
+            //GoogleCredential credential = GoogleCredential.FromFile(Environment.GetEnvironmentVariable("GOOGLE_APPLICATION_CREDENTIALS"));
+            var storage = StorageClient.Create();
             Stream fileStream;
             // check if file path is url
             if (filePath.StartsWith("http"))
@@ -56,8 +56,9 @@ public static string MakePublic(string objectName = "your-object-name")
             storageObject.Acl ??= new List<ObjectAccessControl>();
             storage.UpdateObject(storageObject, new UpdateObjectOptions { PredefinedAcl = PredefinedObjectAcl.PublicRead });
             Console.WriteLine(objectName + " is now public and can be fetched from " + storageObject.SelfLink);
-
-            return storageObject.SelfLink;
+            // get public url
+            var publicUrl = $"https://storage.googleapis.com/{Consts.BUCKET_NAME}/{objectName}";
+            return publicUrl;
         }
 
         public static bool IsFileExist(string objectName = "your-object-name")