Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Pronouns #274

Closed
wants to merge 4 commits into from
Closed

Feat: Pronouns #274

wants to merge 4 commits into from

Conversation

showierdata9978
Copy link
Member

@showierdata9978 showierdata9978 commented Aug 12, 2024

closes #272

Copy link

@Supernoodles99 Supernoodles99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hamburger

@esk33

This comment was marked as off-topic.

@showierdata9978

This comment was marked as off-topic.

@JoshAtticus

This comment was marked as off-topic.

@JoshAtticus
Copy link
Member

but being fr, having an array and stuff is too complex, it can just be a single string, like tnix also said on meower, see https://leo.atticat.tech/share/?id=4bff790b-cca9-42e5-834f-99b0868f9680

@esk33
Copy link
Contributor

esk33 commented Aug 13, 2024

I agree with Josh, this seems like an overengineered solution considering the problem it is trying to solve

@showierdata9978
Copy link
Member Author

I ain't changing the format

@JoshAtticus
Copy link
Member

I ain't changing the format

then this pr should be closed

@mybearworld
Copy link

It might be a bit difficult to create a UI for entering these like that with clients. I think just using strings would be better.

{
  "pronouns": ["he/him", "they/them"]
}

@tnix100
Copy link
Member

tnix100 commented Aug 13, 2024

It might be a bit difficult to create a UI for entering these like that with clients. I think just using strings would be better.

{
  "pronouns": ["he/him", "they/them"]
}

I think this is what's going to be implemented now.

@showierdata9978
Copy link
Member Author

yep

@CST1229
Copy link
Member

CST1229 commented Aug 13, 2024

I would suggest going the Discord route and just having one text field.

{
"pronouns": "he/they"
}

@showierdata9978
Copy link
Member Author

that was already 100% ruled out.

@JoshAtticus
Copy link
Member

that was already 100% ruled out.

you don't make that decision afaik

@showierdata9978
Copy link
Member Author

image

@JoshAtticus
Copy link
Member

image

who said it was going to be merged then?

Copy link
Member

@tnix100 tnix100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be changed to just a string. I still think an array of strings is too much.

@showierdata9978
Copy link
Member Author

This should be changed to just a string. I still think an array of strings is too much.

no

@mybearworld
Copy link

This should be changed to just a string. I still think an array of strings is too much.

Why is it too much? It would be nice to be able to have a "preferred" pronoun that could be displayed inline on posts, but to also have another/others that could be displayed on a profile, for instance

@tnix100
Copy link
Member

tnix100 commented Aug 14, 2024

This should be changed to just a string. I still think an array of strings is too much.

Why is it too much? It would be nice to be able to have a "preferred" pronoun that could be displayed inline on posts, but to also have another/others that could be displayed on a profile, for instance

You can always use your quote to have more, or link to something like pronouns.page. I don't think Meower as a chat platform needs to have all your pronouns, just the one you most prefer is enough in my opinion.

@mybearworld
Copy link

You can always use your quote to have more, or link to something like pronouns.page. I don't think Meower as a chat platform needs to have all your pronouns, just the one you most prefer is enough in my opinion.

That makes sense

@williamhorning williamhorning deleted the showier-pronouns branch August 15, 2024 01:56
@williamhorning
Copy link
Contributor

pronoun support is something i'm in favor of adding but the amount of bikeshedding and the focus on rewriting events makes this extremely low priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add pronouns to user profiles
9 participants