-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Pronouns #274
Feat: Pronouns #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hamburger
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
but being fr, having an array and stuff is too complex, it can just be a single string, like tnix also said on meower, see https://leo.atticat.tech/share/?id=4bff790b-cca9-42e5-834f-99b0868f9680 |
I agree with Josh, this seems like an overengineered solution considering the problem it is trying to solve |
I ain't changing the format |
then this pr should be closed |
It might be a bit difficult to create a UI for entering these like that with clients. I think just using strings would be better. {
"pronouns": ["he/him", "they/them"]
} |
I think this is what's going to be implemented now. |
yep |
I would suggest going the Discord route and just having one text field. {
"pronouns": "he/they"
} |
that was already 100% ruled out. |
you don't make that decision afaik |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be changed to just a string. I still think an array of strings is too much.
no |
Why is it too much? It would be nice to be able to have a "preferred" pronoun that could be displayed inline on posts, but to also have another/others that could be displayed on a profile, for instance |
You can always use your quote to have more, or link to something like pronouns.page. I don't think Meower as a chat platform needs to have all your pronouns, just the one you most prefer is enough in my opinion. |
That makes sense |
pronoun support is something i'm in favor of adding but the amount of bikeshedding and the focus on rewriting events makes this extremely low priority |
closes #272