Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've bundled what should be multiple MRs into one to get some feedback in case you're dead against the changes.
I've been working on compiling fwupd for android using the NDK and including libgbinder as a meson subproject.
The android implementation of libc (bionic) doesn't include
pthread_timedjoin_np
so I've added a path that just usespthread_join
, it seems to work.I've included a much less fleshed out
meson.build
file for libglibutil which I need to work on a bit before submitting upstream.