-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: garm v0.1.5 #158
base: main
Are you sure you want to change the base?
feat: garm v0.1.5 #158
Conversation
@@ -1,5 +1,3 @@ | |||
# SPDX-License-Identifier: MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add PROJECT
to the list of generated files in the license-scanner-script:
https://github.com/mercedes-benz/garm-operator/blob/main/hack/verify-license.sh#L22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, let's introduce a new API group
api/v1alpha1/enterprise_types.go
Outdated
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
|
||
"github.com/mercedes-benz/garm-operator/pkg/util/conditions" | ||
) | ||
|
||
// EnterpriseSpec defines the desired state of Enterprise | ||
type EnterpriseSpec struct { | ||
CredentialsName string `json:"credentialsName"` | ||
CredentialsRef corev1.TypedLocalObjectReference `json:"credentialsRef"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, let's introduce a new API version (e.g. v1beta1
) to cover the change in the CredentialsRef
with a conversion.
group: garm-operator | ||
kind: GitHubCredentials | ||
path: github.com/mercedes-benz/garm-operator/api/v1alpha1 | ||
version: v1alpha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new API groups should be in v1beta1
group: garm-operator | ||
kind: GitHubEndpoint | ||
path: github.com/mercedes-benz/garm-operator/api/v1alpha1 | ||
version: v1alpha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new API groups should be in v1beta1
group: garm-operator | ||
kind: GarmServerConfig | ||
path: github.com/mercedes-benz/garm-operator/api/v1alpha1 | ||
version: v1alpha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new API groups should be in v1beta1
this adds the conversion generator from https://github.com/kubernetes/code-generator to generate conversion code Signed-off-by: Mario Constanti <[email protected]>
Signed-off-by: Mario Constanti <[email protected]>
code got generated by make conversion Signed-off-by: Mario Constanti <[email protected]>
Signed-off-by: Mario Constanti <[email protected]>
88fcd0d
to
4231a28
Compare
This PR attempts to implement the new set of changes and api changes garm requires for its version v0.1.5. This includes: