Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make lint で lint を実行しつつ、CI で lint と test を実行 #3

Merged
merged 16 commits into from
Mar 15, 2024

Conversation

meriy100
Copy link
Owner

  • ci: add golangci
  • refact: gci で import 順序を整形
  • chore: gocognit を 54 に設定 / ただし、最終的に 10 にする
  • chore(cmd/http): ローカルで http サーバたてて開発することはないので削除
  • refact(cmd/cli): os.Exit ではなく panic で終わらせる
  • chore: bin/ を gitignore
  • refact(interfaces/repositories): esa api resposnse status const
  • refact(entities): SplitN の N を const
  • refact(adapters): vercel api resposnse status const
  • refact(entities): SplitN の len case 選択肢を定数化
  • refact(usecases): 不要なプロパティの削除
  • refact(interfaces/presenters/http): fmt.Fprintf => fmt.Fprint
  • refact(entities): month の スプリット結果の比較を定数化
  • refact(usecases): esa post id を定数化 / 環境変数 に移す予定
  • refact(usecase): nil チェックで弾かれたらテストを終わらす
  • ci: lint とテストを実行

@meriy100 meriy100 merged commit 43326d8 into main Mar 15, 2024
3 checks passed
@meriy100 meriy100 deleted the ci-lint branch March 15, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant