fix: eslint ignore, type definition

mermaid-js · Apr 14, 2024 · 5b6c5df · 5b6c5df
1 parent 7fa887b
commit 5b6c5df
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 23 deletions.
diff --git a/.eslintignore b/.eslintignore
diff --git a/.eslintignore b/.eslintignore
@@ -0,0 +1 @@
+.gitignore
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -53,7 +53,7 @@ module.exports = {
     '@typescript-eslint/no-floating-promises': 'error',
     '@typescript-eslint/no-misused-promises': 'error',
     '@typescript-eslint/no-unused-vars': 'warn',
-    '@typescript-eslint/consistent-type-definitions': 'warn',
+    '@typescript-eslint/consistent-type-definitions': 'error',
     '@typescript-eslint/ban-ts-comment': [
       'error',
       {

diff --git a/package.json b/package.json
@@ -25,8 +25,8 @@
     "dev:vite": "tsx .vite/server.ts",
     "dev:coverage": "pnpm coverage:cypress:clean && VITE_COVERAGE=true pnpm dev:vite",
     "release": "pnpm build",
-    "lint": "cross-env NODE_OPTIONS=--max_old_space_size=8192 eslint --cache --cache-strategy content --ignore-path .gitignore . && pnpm lint:jison && prettier --cache --check .",
-    "lint:fix": "cross-env NODE_OPTIONS=--max_old_space_size=8192 eslint --cache --cache-strategy content --fix --ignore-path .gitignore . && prettier --write . && tsx scripts/fixCSpell.ts",
+    "lint": "cross-env NODE_OPTIONS=--max_old_space_size=8192 eslint --cache --cache-strategy content . && pnpm lint:jison && prettier --cache --check .",
+    "lint:fix": "cross-env NODE_OPTIONS=--max_old_space_size=8192 eslint --cache --cache-strategy content --fix . && prettier --write . && tsx scripts/fixCSpell.ts",
     "lint:jison": "tsx ./scripts/jison/lint.mts",
     "contributors": "tsx scripts/updateContributors.ts",
     "cypress": "cypress run",

diff --git a/packages/mermaid/src/diagrams/class/classTypes.ts b/packages/mermaid/src/diagrams/class/classTypes.ts
@@ -138,7 +138,7 @@ export interface ClassNote {
   text: string;
 }
 
-export type ClassRelation = {
+export interface ClassRelation {
   id1: string;
   id2: string;
   relationTitle1: string;
@@ -152,7 +152,7 @@ export type ClassRelation = {
     type2: number;
     lineType: number;
   };
-};
+}
 
 export interface NamespaceNode {
   id: string;

diff --git a/packages/mermaid/src/diagrams/quadrant-chart/quadrantDb.ts b/packages/mermaid/src/diagrams/quadrant-chart/quadrantDb.ts
@@ -17,7 +17,10 @@ function textSanitizer(text: string) {
   return sanitizeText(text.trim(), config);
 }
 
-type LexTextObj = { text: string; type: 'text' | 'markdown' };
+interface LexTextObj {
+  text: string;
+  type: 'text' | 'markdown';
+}
 
 const quadrantBuilder = new QuadrantBuilder();
 

diff --git a/packages/parser/src/language/info/module.ts b/packages/parser/src/language/info/module.ts
@@ -19,12 +19,12 @@ import { InfoTokenBuilder } from './tokenBuilder.js';
 /**
  * Declaration of `Info` services.
  */
-type InfoAddedServices = {
+interface InfoAddedServices {
   parser: {
     TokenBuilder: InfoTokenBuilder;
     ValueConverter: CommonValueConverter;
   };
-};
+}
 
 /**
  * Union of Langium default services and `Info` services.

diff --git a/packages/parser/src/language/packet/module.ts b/packages/parser/src/language/packet/module.ts
@@ -19,12 +19,12 @@ import { PacketTokenBuilder } from './tokenBuilder.js';
 /**
  * Declaration of `Packet` services.
  */
-type PacketAddedServices = {
+interface PacketAddedServices {
   parser: {
     TokenBuilder: PacketTokenBuilder;
     ValueConverter: CommonValueConverter;
   };
-};
+}
 
 /**
  * Union of Langium default services and `Packet` services.

diff --git a/packages/parser/src/language/pie/module.ts b/packages/parser/src/language/pie/module.ts
@@ -19,12 +19,12 @@ import { PieValueConverter } from './valueConverter.js';
 /**
  * Declaration of `Pie` services.
  */
-type PieAddedServices = {
+interface PieAddedServices {
   parser: {
     TokenBuilder: PieTokenBuilder;
     ValueConverter: PieValueConverter;
   };
-};
+}
 
 /**
  * Union of Langium default services and `Pie` services.