Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Elk Tests #4111

Closed
wants to merge 4 commits into from
Closed

Fix Elk Tests #4111

wants to merge 4 commits into from

Conversation

sidharthv96
Copy link
Member

📑 Summary

Elk tests were very flaky during continuous tests.
Random test cases were failing intermittently.
So it's disabled in release/10.0.0.
This PR will re enable it.

📏 Design Decisions

No need to waste time fixing elk tests on v10 PR.
Can investigate and fix in this PR even after v10 release.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 📓 have added documentation (if appropriate)
  • 🔖 targeted develop branch

@sidharthv96 sidharthv96 changed the base branch from develop to release/10.0.0 February 19, 2023 19:04
Base automatically changed from release/10.0.0 to master February 20, 2023 12:28
@sidharthv96 sidharthv96 changed the base branch from master to release/10.0.0 February 20, 2023 12:47
@sidharthv96 sidharthv96 changed the base branch from release/10.0.0 to develop February 24, 2023 12:06
@netlify
Copy link

netlify bot commented Sep 6, 2023

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 212b368
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/64f8b6c18d5ea8000809a8b0
😎 Deploy Preview https://deploy-preview-4111--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #4111 (212b368) into develop (773abbe) will increase coverage by 25.62%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #4111       +/-   ##
============================================
+ Coverage    45.16%   70.79%   +25.62%     
============================================
  Files           53      133       +80     
  Lines         6671    14040     +7369     
  Branches        32      555      +523     
============================================
+ Hits          3013     9939     +6926     
- Misses        3657     3978      +321     
- Partials         1      123      +122     
Flag Coverage Δ
e2e 75.75% <ø> (?)
unit 45.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 129 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant