Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add Mermaid for Slack integration #4824

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

JackuB
Copy link
Contributor

@JackuB JackuB commented Sep 8, 2023

📑 Summary

Adds a Mermaid for Slack integration: https://github.com/JackuB/mermaid-for-slack

📋 Tasks

Make sure you

@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 4559ba6
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6523001cd7f3b00008d9bf1a
😎 Deploy Preview https://deploy-preview-4824--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #4824 (4559ba6) into develop (12a4707) will increase coverage by 0.30%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4824      +/-   ##
===========================================
+ Coverage    79.97%   80.28%   +0.30%     
===========================================
  Files          164      164              
  Lines        13623    13623              
  Branches       693      693              
===========================================
+ Hits         10895    10937      +42     
+ Misses        2579     2537      -42     
  Partials       149      149              
Flag Coverage Δ
e2e 85.65% <ø> (+0.38%) ⬆️
unit 43.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@huynhicode
Copy link
Member

Thanks for your PR @JackuB - great integration!

Looks like there is a listing issue. Try running pnpm lint:fix.

@JackuB
Copy link
Contributor Author

JackuB commented Oct 3, 2023

@huynhicode My bad! I misread the path in Contributing docs and edited a wrong file 🤦
Just pushed an updated commit

@sidharthv96 sidharthv96 added this pull request to the merge queue Nov 8, 2023
Merged via the queue into mermaid-js:develop with commit d1fba9c Nov 8, 2023
16 checks passed
Copy link

mermaid-bot bot commented Nov 8, 2023

@JackuB, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants