Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/4730_Syntax_error_in_text_appears_under_the_body_tag. #4877

Closed

Conversation

AlanOchoaMtz
Copy link

📑 Summary

Syntax error in text appears under the body tag resolved by replacing "crit1" instead of "crit"

Resolves #4730

📏 Design Decisions

I replaced the syntaxError for the reporter suggestion for this fix.

📋 Tasks

Make sure you

@netlify
Copy link

netlify bot commented Sep 27, 2023

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 38bdacf
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/652c1a20830874000844371c
😎 Deploy Preview https://deploy-preview-4877--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AlanOchoaMtz AlanOchoaMtz changed the title Syntax error in text appears under the body tag. #4730 bug/4730_Syntax_error_in_text_appears_under_the_body_tag. Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #4877 (38bdacf) into develop (df068db) will increase coverage by 0.33%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4877      +/-   ##
===========================================
+ Coverage    79.94%   80.28%   +0.33%     
===========================================
  Files          164      164              
  Lines        13623    13623              
  Branches       693      693              
===========================================
+ Hits         10891    10937      +46     
+ Misses        2583     2537      -46     
  Partials       149      149              
Flag Coverage Δ
e2e 85.65% <ø> (+0.42%) ⬆️
unit 43.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid/src/diagrams/gantt/styles.js 100.00% <ø> (ø)

... and 7 files with indirect coverage changes

@sidharthv96
Copy link
Member

:crit is the syntax, using :crit1 throws error, which is expected. We should not change the code to fix that.
The problem is that the syntax error appears under the editor, not in the view panel. That was the error to be fixed.

@sidharthv96 sidharthv96 closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax error in text appears under the body tag.
2 participants