bug: #4905 change shiki theme to github-light #4924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4924 +/- ##
===========================================
- Coverage 75.34% 42.88% -32.46%
===========================================
Files 164 23 -141
Lines 13820 5009 -8811
Branches 693 21 -672
===========================================
- Hits 10412 2148 -8264
+ Misses 3238 2860 -378
+ Partials 170 1 -169
Flags with carried forward coverage won't be shown. Click here to find out more. |
sidharthv96
requested changes
Oct 11, 2023
4 tasks
|
@raiman264 Looks like there is a linting issue. Can you try running |
sidharthv96
force-pushed
the
bug/4905_fix_code_block_unreadable_text
branch
from
3e12e84 to
8db9700
Compare
|
@raiman264, Thank you for the contribution! |
This was referenced Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Changes the theme of shiki to github-light in order to propertly show all text with the light background
another way around could be to change the code block background to a darker one,
please let me know if you prefer it that way.
Resolves #4905
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
before / after
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch