-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #4979
Update README.md #4979
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4979 +/- ##
===========================================
- Coverage 80.13% 79.37% -0.77%
===========================================
Files 164 164
Lines 13815 13815
Branches 693 693
===========================================
- Hits 11071 10966 -105
- Misses 2594 2700 +106
+ Partials 150 149 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
@karthxk07 Thanks for your PR! I think in the context of the docs, using "has" makes more sense than using "have" since docs has an it pronoun. Maybe you can update the verbiage to something like, "For video tutorials, visit our Tutorials page." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
@huynhicode Yup, that sounds better , I will make the change right away. |
@karthxk07, Thank you for the contribution! |
📑 Summary
Updated the Readme.md file to change a typo
Resolves #4978
📏 Design Decisions
In the sentence "Tutorials has video tutorials," it should be "Tutorials have video tutorials" for subject-verb agreement.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch