Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix case that generate broken link on docs #5006

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

lchenay
Copy link
Contributor

@lchenay lchenay commented Nov 2, 2023

📑 Summary

Documentation url are case sensitive. This Typo generate broken link on all the documentation page when you want to go to XYchart.

📋 Tasks

Make sure you

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 379722d
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/65438db83102f80008246727
😎 Deploy Preview https://deploy-preview-5006--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #5006 (379722d) into develop (f5bd1e0) will increase coverage by 36.45%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #5006       +/-   ##
============================================
+ Coverage    42.94%   79.39%   +36.45%     
============================================
  Files           23      164      +141     
  Lines         4972    13820     +8848     
  Branches        21      693      +672     
============================================
+ Hits          2135    10973     +8838     
+ Misses        2836     2698      -138     
- Partials         1      149      +148     
Flag Coverage Δ
e2e 85.26% <ø> (?)
unit 42.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 160 files with indirect coverage changes

Copy link
Member

@aloisklink aloisklink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like PR #5014 has already fixed this issue. Sorry about that, your PR was made first, so we should have reviewed and merged it first.

But, it looks like since your changes are exactly the same as that PR, so we might be able to merge this PR too, so you also get a contribution credit for fixing a bug!

@aloisklink aloisklink added this pull request to the merge queue Nov 28, 2023
@aloisklink aloisklink added Area: Documentation Skip changelog Don't include in the changelog labels Nov 28, 2023
Merged via the queue into mermaid-js:develop with commit 72d2d04 Nov 28, 2023
17 checks passed
Copy link

mermaid-bot bot commented Nov 28, 2023

@lchenay, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

@lchenay
Copy link
Contributor Author

lchenay commented Nov 28, 2023

We don't do PR to be first.
We do it to improve a project.
You can close it if it's fixed by another one ; fixing situation is the main purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Documentation Skip changelog Don't include in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants