Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: mermaid image size zero #5058

Closed

Conversation

bonyuta0204
Copy link
Contributor

📑 Summary

Brief description about the content of your PR.

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 0e8ea99
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/655e05220a4b12000800cd32
😎 Deploy Preview https://deploy-preview-5058--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #5058 (0e8ea99) into develop (4a4e614) will increase coverage by 36.78%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #5058       +/-   ##
============================================
+ Coverage    42.91%   79.69%   +36.78%     
============================================
  Files           23      164      +141     
  Lines         5029    13870     +8841     
  Branches        21      698      +677     
============================================
+ Hits          2158    11054     +8896     
+ Misses        2870     2666      -204     
- Partials         1      150      +149     
Flag Coverage Δ
e2e 85.69% <100.00%> (?)
unit 42.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid/src/dagre-wrapper/shapes/util.js 96.29% <100.00%> (ø)

... and 159 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant