Changes to Gantt Parsers to allow hashes and semicolons to titles, sections, and task data.

[FutzMonitor]

📑 Summary

This PR makes changes to the gantt.jison file that allows users to use hash and semicolons in the title, section, and task title.

Resolves #1981

📏 Design Decisions

Changes to gnatt.jison

1. Removed the hash and semicolon symbols from the title regex to allow for their use.
2. Removed the hash and semicolon symbols from the section regex to allow fortheir use.
3. Removed the hash and semicolon symbols for the taskTxt regex to allow for their use. I did not remove the colon because the parser fails to recognize when the actual taskData begins if that distinctions isn't kept.
4. Removed the regex #[^\n]* which skipped comments to fix some bugs with hash symbols in the taskTxt. I tested this changed by putting it back and using the comment ## hello world to see if it was recognized as a comment, but I would receive a syntax error and the diagram would not be rendered. So, I think we can safely remove that line, BUT it would be best practice if someone else tested this change to ensure that this will not break anyone's Gantt diagrams."

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• 💻 have added necessary unit/e2e tests.
• 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
• 🔖 targeted develop branch

[netlify]

✅ Deploy Preview for mermaid-js ready!

Name	Link
🔨 Latest commit	59264a3
🔍 Latest deploy log	https://app.netlify.com/sites/mermaid-js/deploys/65b3e286930dd90008642061
😎 Deploy Preview	https://deploy-preview-5095--mermaid-js.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6939cf5) 80.16% compared to head (59264a3) 79.36%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #5095      +/-   ##
===========================================
- Coverage    80.16%   79.36%   -0.80%     
===========================================
  Files          167      167              
  Lines        13902    13902              
  Branches       707      707              
===========================================
- Hits         11145    11034     -111     
- Misses        2604     2715     +111     
  Partials       153      153              

Flag	Coverage Δ
e2e	85.16% <ø> (-1.01%)	⬇️
unit	43.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

[FutzMonitor]

Does the Netlify error "Failed during stage Install dependencies": dependency_installation script returned non-zero exit code: 1 have anything to do with the changes that I've made? I'm unsure since it's part of the build.ts and no reference is necessarily made to my changes.

[aloisklink]

Does the Netlify error "Failed during stage Install dependencies": dependency_installation script returned non-zero exit code: 1 have anything to do with the changes that I've made? I'm unsure since it's part of the build.ts and no reference is necessarily made to my changes.

It looks like Node.JS v18.19.0 broke the ts-node-esm command that we use to build Mermaid, and Netlify just switched to using it by default. So no, it's nothing to do with your PR.

I've made a PR fixing it: #5097.

[FutzMonitor]

When you use # in the live editor, it doesn't break the live editor. However, I believe we have to make this functionality visually consistent to %% by styling the text green.

These changes should be followed with updates to the Gantt documentation because there's no mention of this functionality there [link].

[nirname]

LGTM

[sidharthv96]

Please add unit tests and rendering tests for the newly supported cases, along with updates to the documentation.

[FutzMonitor]

Sounds good. I'll look at the other tests for guidance and update affected documentation.

[FutzMonitor]

I added some unit tests and rendering tests. I looked through the documentation, and I didn't find any explicit instances mentioning that semicolons and hashtags weren't allowed. So, I didn't add anything in terms of documentation. I did add another graph in gantt.html to demonstrate the semicolons and hashtags are fine.