feat: Add getConfigValue
#5251
feat: Add getConfigValue
#5251
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## sidv/mindmapToTs #5251 +/- ##
=====================================================
- Coverage 80.08% 43.25% -36.84%
=====================================================
Files 167 23 -144
Lines 13867 5056 -8811
Branches 741 23 -718
=====================================================
- Hits 11106 2187 -8919
- Misses 2594 2868 +274
+ Partials 167 1 -166
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
It is typesafe though, both the path and the return value will be properly typed. 
|
| @@ -47,7 +47,7 @@ const addNode = (level: number, id: string, descr: string, type: number) => { | |||
| descr: sanitizeText(descr, conf), | |||
| type, | |||
| children: [], | |||
| width: conf.mindmap?.maxNodeWidth ?? defaultConfig.mindmap.maxNodeWidth, | |||
| width: getConfigValue(conf, 'mindmap.maxNodeWidth'), | |||
There was a problem hiding this comment.
I'm also not a big fan of this syntax, since it makes things more complicated.
Ideally, we'd instead change getConfig() to return RequiredDeep<MermaidConfig>.
The only reason I haven't yet is that some of the config values don't have default values, because undefined is a valid value for them. Ideally, I'd go through the config and change every value that currently accepts undefined to instead use null, that way we can safely do RequiredDeep<MermaidConfig> and still keep the null types.
Then we could just do: conf.mindmap.maxNodeWidth.
| path: Path | ||
| ): Get<RequiredDeep<MermaidConfig>, Path> => { | ||
| let value = lodashGet(config, path) as Get<RequiredDeep<MermaidConfig>, Path>; | ||
| if (!value) { |
There was a problem hiding this comment.
This doesn't work for values that valid but falsy, false, 0, or "".
No description provided.