-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(git-graph): GitGraph Bottom-to-Top Orientation #5259
feat(git-graph): GitGraph Bottom-to-Top Orientation #5259
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5259 +/- ##
==========================================
- Coverage 5.74% 5.72% -0.02%
==========================================
Files 277 277
Lines 41751 41896 +145
Branches 27 27
==========================================
Hits 2400 2400
- Misses 39350 39495 +145
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
If e2e tests are needed, I will work on them. I will also work on the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, works well! Nice work 🚀
Only some minor comments.
We also need
- The documentation in
mermaid/packages/mermaid/src/docs/syntax/gitgraph.md
- Rendering tests in
cypress/integration/rendering/gitGraph.spec.js
Updated Documentation. Currently working on the Cypress E2E. I found that the |
Finished adding Cypress E2E test cases and logic for handling |
I did make the requested changes, but please let me know if there are any other mistakes/errors. Sorry about the bad test/doc conventions. I should've read |
Please resolve the conflicts. |
5f46276
to
10fb856
Compare
@sidharthv96 I am really sorry about this; I badly polluted the commits with some of the merge conflicts and had to hard reset to the up-to-date dev branch and recommit my feature. Some of the changes in the renderer had conflicts with my logic and I had to rewrite them. I added more examples on |
@JingyuMarcelLee, Thank you for the contribution! |
feat(git-graph): GitGraph BT feature:
📑 Summary
Added Bottom-to-Top orientation for the gitGraph. Added
BT
togitGraph.jison
under"DIR"
token and tested this atgitGraphParser.spec.js
. Made changes to thegitGraphRenderer.js
to correctly render the bottom-to-top orientation of the gitGraph.Resolves #5239
📏 Design Decisions
gitGraphRenderer.js
, I reversed the array that stored the commit nodes so they can be rendered from bottom to top.gitGraph BT:
example under/demos/git.html
gitGraphParser.spec.js
to check ifBT
option can be correctly parsed.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch