-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/5245 sequence diagram add classes to actors text #5272
Feature/5245 sequence diagram add classes to actors text #5272
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5272 +/- ##
============================================
+ Coverage 43.22% 79.51% +36.29%
============================================
Files 23 175 +152
Lines 5037 14398 +9361
Branches 23 855 +832
============================================
+ Hits 2177 11449 +9272
+ Misses 2859 2755 -104
- Partials 1 194 +193
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@aloisklink would appreciate your input on this :) |
Hey @sidharthv96 and @aloisklink would love to get some input on this. This seems to be a desired feature, would be great to get it in. |
📑 Summary
Added unique classes to actors
text
tags to enable different styling to the text of actor box and actor man figure.Added
actor-box
class to the actor boxtext
Added
actor-man
class to the actor figuretext
Resolves #5245 and #3099
📏 Design Decisions
n/a
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch