Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/5245 sequence diagram add classes to actors text #5272

Conversation

Ronid1
Copy link
Contributor

@Ronid1 Ronid1 commented Feb 6, 2024

📑 Summary

Added unique classes to actors text tags to enable different styling to the text of actor box and actor man figure.
Added actor-box class to the actor box text
Added actor-man class to the actor figure text

Resolves #5245 and #3099

📏 Design Decisions

n/a

📋 Tasks

Make sure you

Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 6c0be03
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/65fe8c6e8937b800081b9699
😎 Deploy Preview https://deploy-preview-5272--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the Type: Enhancement New feature or request label Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c6ad54) 43.22% compared to head (c3d9aa7) 79.51%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #5272       +/-   ##
============================================
+ Coverage    43.22%   79.51%   +36.29%     
============================================
  Files           23      175      +152     
  Lines         5037    14398     +9361     
  Branches        23      855      +832     
============================================
+ Hits          2177    11449     +9272     
+ Misses        2859     2755      -104     
- Partials         1      194      +193     
Flag Coverage Δ
e2e 85.09% <100.00%> (?)
unit 43.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid/src/diagrams/sequence/svgDraw.js 91.03% <100.00%> (ø)

... and 169 files with indirect coverage changes

@Ronid1
Copy link
Contributor Author

Ronid1 commented Feb 29, 2024

@aloisklink would appreciate your input on this :)

@Ronid1
Copy link
Contributor Author

Ronid1 commented Mar 20, 2024

Hey @sidharthv96 and @aloisklink would love to get some input on this. This seems to be a desired feature, would be great to get it in.

@sidharthv96 sidharthv96 merged commit d5b1028 into mermaid-js:develop Mar 23, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sequence Diagram actor man text should have a unique class
2 participants