feat: add name attribute and class "actor-line" to line

[ad1992]

📑 Summary

• The actors have unique names so adding a name field to the line connecting the actors for easier identification in SVG nodes.
• Additionally fixes a bug - actor-line class was never added to the line as it was getting overridden so now that's fixed as well

cc @sidharthv96

<line id="actor11" x1="714" y1="5" x2="714" y2="621" class="actor-line 200" stroke-width="0.5px" stroke="#999" name="4"></line>

📏 Design Decisions

similar to #5284, this is adding a unique identifier for line nodes connecting the actors

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• 💻 have added necessary unit/e2e tests.
• 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
• 🔖 targeted develop branch

[netlify]

✅ Deploy Preview for mermaid-js ready!

Name	Link
🔨 Latest commit	233944b
🔍 Latest deploy log	https://app.netlify.com/sites/mermaid-js/deploys/65eaa73b2a1d280008835b99
😎 Deploy Preview	https://deploy-preview-5338--mermaid-js.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 44.67%. Comparing base (4884b01) to head (233944b).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #5338   +/-   ##
========================================
  Coverage    44.67%   44.67%           
========================================
  Files           25       25           
  Lines         5339     5341    +2     
  Branches        27       27           
========================================
+ Hits          2385     2386    +1     
- Misses        2953     2954    +1     
  Partials         1        1           

Flag	Coverage Δ
unit	44.67% <25.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
packages/mermaid/src/themes/theme-default.js	94.37% <100.00%> (+0.01%)	⬆️
packages/mermaid/src/themes/theme-base.js	3.81% <0.00%> (ø)
packages/mermaid/src/themes/theme-dark.js	2.74% <0.00%> (ø)
packages/mermaid/src/themes/theme-forest.js	3.80% <0.00%> (-0.02%)	⬇️
packages/mermaid/src/themes/theme-neutral.js	4.55% <0.00%> (ø)

[ad1992]

@sidharthv96 how can I update the failing snapshots ?

[sidharthv96]

@ad1992 you can't fix snapshots in CI, as they are regenerated from the base branch. But we'll review and merge it, no issues.

@mermaid-js/atlantians this an example of the change. All the failing tests contain this exact change in line color.

[ad1992]

@ad1992 you can't fix snapshots in CI, as they are regenerated from the base branch. But we'll review and merge it, no issues.

@mermaid-js/atlantians this an example of the change. All the failing tests contain this exact change in line color.

Awesome, thanks @sidharthv96 , let me know if there is anything needed from my side to merge this

[aloisklink]

The code changes look good to me! Thanks for catching this.

The visual changes are okay to me, but I'd very slightly prefer if we keep existing sequence diagrams looking the same (it would also mean the E2E snapshots won't change!), by changing the default actorLineColor var to match what it was for the last few years (e.g. the same colour as the actorBorder). But I'm happy to be convinced otherwise.

@sidharthv96, @ad1992, any thoughts on what looks nicer?

[ad1992]

I have made the changes, however I am getting "Resource not accessible by integration" due to which E2E is failing,
any idea @aloisklink ?

[aloisklink]

Hi @ad1992, don't worry, I don't think it's your fault! It looks like #5235 added a new feature to the E2E CI tests that doesn't work for PRs from forks.

I've made a PR that should fix this in #5365.

All of your changes look great to me, but I'll have to wait until #5365 is merged before I can merge this.

[sidharthv96]

Single failure

[ad1992]

Alright lets merge this @aloisklink @sidharthv96 😊