build(deps): update langium to v3 and apply the required changes
#5345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #5345 +/- ##
=======================================
Coverage 44.67% 44.67%
=======================================
Files 25 25
Lines 5339 5339
Branches 27 27
=======================================
Hits 2385 2385
Misses 2953 2953
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. |
* next: (100 commits) Resolves E2E testing issues and issue mermaid-js#5343 Fix spelling Fix community integrations Fix docs docs: Fix config Update all minor dependencies Amend docs to document gitgraph parallel commits Fix lint Use Yarn Add COREPACK_ENABLE_STRICT Added link to Blazorade Mermaid to the community integrations page. Bump node version Add lcov to cspell Correcting path to docker-entrypoint.sh Update recommended Vitest extension Replace mermaid-js.github.io links Replace links to docs with links to webhelp Link to contributing page on webhelp Changes to timeline.md 1. Added colons to all 'NOTES' for consistency. Changes to timeline.md 1. Updates the Wikipedia citation to include a link. 2. Removed periods from documentation sections to be consistent (some had periods, some didn't) 3. Added a space to a coding example for spacing consistency. Replace version number placeholder ...
|
next 
v3 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
By the update
langiumtov3, it should decrease the parser package size by around 1/3rd of the bundle, see: eclipse-langium/langium#1258 (comment).This PR would be consider as a
BREAKING CHANGEin themermaid-js/parserpackage, because we export the modified interfaces and functions.📏 Design Decisions
Applied the changes description in eclipse-langium/langium#1258 (comment) and https://github.com/eclipse-langium/langium/blob/18a38cedb427d36bb955dd854548e9173955b2f8/packages/langium/CHANGELOG.md#smaller-bundles-with-exports.
📋 Tasks
Make sure you