Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update entityRelationshipDiagram.md #5413

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

anlai46
Copy link
Contributor

@anlai46 anlai46 commented Mar 25, 2024

📑 Summary

  • Added the Wikipedia link
  • Removed a comma at the end of a bullet point that is likely unintended
  • Removed an additional period under the "Additional Keys and Comments" section

Resolves

📏 Design Decisions

I made minor corrections to the entityRelationshipDiagram.md file. Specifically, I added a link to the Wikipedia page and removed accidental punctuation marks to improve readability.

📋 Tasks

Make sure you

- Added Wikipedia link
- Removed comma "," at the end of a bullet point
- Removed additional period "."
Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 43e183b
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6600d8d7e922af00082dd3f9
😎 Deploy Preview https://deploy-preview-5413--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.72%. Comparing base (c00bf26) to head (43e183b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5413   +/-   ##
=======================================
  Coverage     5.72%   5.72%           
=======================================
  Files          277     277           
  Lines        41896   41896           
  Branches        27      27           
=======================================
  Hits          2400    2400           
  Misses       39495   39495           
  Partials         1       1           
Flag Coverage Δ
unit 5.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sidharthv96 sidharthv96 merged commit c5cc9db into mermaid-js:develop Mar 25, 2024
18 of 19 checks passed
Copy link

mermaid-bot bot commented Mar 25, 2024

@anlai46, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants