Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sequenceDB typesafe #5426

Merged
merged 12 commits into from
Apr 14, 2024
Merged

Conversation

ad1992
Copy link
Contributor

@ad1992 ad1992 commented Mar 29, 2024

📑 Summary

  • Make Sequencedb typesafe
  • Add eslint rule for consistent type definations

📋 Tasks

Make sure you

Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 2a3d032
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/661a250253a3190008426909
😎 Deploy Preview https://deploy-preview-5426--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 95 lines in your changes are missing coverage. Please review.

Project coverage is 5.74%. Comparing base (9ed2f4b) to head (2a3d032).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5426      +/-   ##
==========================================
- Coverage     5.74%   5.74%   -0.01%     
==========================================
  Files          276     276              
  Lines        41886   41902      +16     
  Branches       514     514              
==========================================
  Hits          2407    2407              
- Misses       39479   39495      +16     
Flag Coverage Δ
unit 5.74% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.eslintrc.cjs 0.00% <0.00%> (ø)
packages/mermaid/src/utils/imperativeState.ts 0.00% <0.00%> (ø)
...ckages/mermaid/src/diagrams/sequence/sequenceDb.ts 0.00% <0.00%> (ø)

@ad1992 ad1992 marked this pull request as ready for review March 29, 2024 10:14
Copy link
Member

@sidharthv96 sidharthv96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @ad1992 !

packages/mermaid/src/diagrams/sequence/sequenceDb.ts Outdated Show resolved Hide resolved
packages/mermaid/src/diagrams/sequence/sequenceDb.ts Outdated Show resolved Hide resolved
packages/mermaid/src/diagrams/sequence/sequenceDb.ts Outdated Show resolved Hide resolved
packages/mermaid/src/diagrams/sequence/sequenceDb.ts Outdated Show resolved Hide resolved
packages/mermaid/src/diagrams/sequence/sequenceDb.ts Outdated Show resolved Hide resolved
@ad1992 ad1992 requested a review from sidharthv96 April 5, 2024 13:03
@ad1992
Copy link
Contributor Author

ad1992 commented Apr 9, 2024

friendly reminder @sidharthv96 ^

@sidharthv96 sidharthv96 added this pull request to the merge queue Apr 14, 2024
Merged via the queue into mermaid-js:develop with commit 7fa887b Apr 14, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants