fix: SequenceDiagram: draw activations even without explicit deactivation #5457
+51
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Activations will now also be drawn, even if there is no deactivation for a participant. The activation will reach down to the bottom or to the point where the participant gets destroyed.
Resolves #3849
📏 Design Decisions
All activations were already parsed correctly and stored in 'bounds.activations'. If no deactivation was existing, it would remain inside this array. This information is now used to draw the 'missing' activations after all actors and messages were drawn already.
If an actor was destroyed, it's last y position is also stored already (
bounds.models.actors[].stopy
), which will then be used as the end of the activation, instead of the end of the diagram.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch