Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5460 - Initial Release for review #5461

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

darkedges
Copy link

#5460
This adds Markdown support for SequenceDiagram notes Needs cleanup.

📑 Summary

This adds Markdown support for notes and syntax highlighting.

Resolves #5460

📏 Design Decisions

Updates the Parser to include support dor multline end support.
Detects if it fins Markdown and uses the Markdown renderer to geneate text.
Follows the same pattern as katexsupport.

📋 Tasks

Make sure you

mermaid-js#5460
This adds Markdown support for SequenceDiagram notes
Needs cleanup.
@github-actions github-actions bot added the Type: Enhancement New feature or request label Apr 13, 2024
Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit ecfe14a
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/661d96848e8c4d000859a8b7
😎 Deploy Preview https://deploy-preview-5461--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@darkedges
Copy link
Author

I need some help cleaning up the parser as that is currently breaking checkins.

Conflict in grammar: multiple actions possible when lookahead token is TXT in state 116
- reduce by rule: note_section -> 
- shift token (then go to state 120)

States with conflicts:
State 116
  note_statement -> note placement actor .text2 #lookaheads= NEWLINE
  note_statement -> note placement actor .note_section end #lookaheads= NEWLINE
  text2 -> .TXT
  note_section -> . #lookaheads= end ACTOR TXT NEWLINE
  note_section -> .note_section note_line #lookaheads= end ACTOR TXT NEWLINE
Conflict in grammar: multiple actions possible when lookahead token is TXT in state 116
- reduce by rule: note_section ->
- shift token (then go to state 120)

States with conflicts:
State 116
  note_statement -> note placement actor .text2 #lookaheads= NEWLINE
  note_statement -> note placement actor .note_section end #lookaheads= NEWLINE
  text2 -> .TXT
  note_section -> . #lookaheads= end ACTOR TXT NEWLINE
  note_section -> .note_section note_line #lookaheads= end ACTOR TXT NEWLINE

also need to include the css requied for highligthing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adding Markdown to SequenceDiagram Notes
1 participant