bug(ClassDiagram): Fixed a combination abstract and static modifiers not working. #5462
+234
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Bug / Error
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5462 +/- ##
==========================================
- Coverage 5.74% 5.73% -0.02%
==========================================
Files 277 278 +1
Lines 41897 41999 +102
Branches 489 490 +1
==========================================
Hits 2407 2407
- Misses 39490 39592 +102
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ged order to reflect code
|
Is there anything I can do to get this PR merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
This pull requests fixes a combination of abstract and static modifiers not working.
Resolves #5459
📏 Design Decisions
I updated the RegEx for detecting methods to take into account a possible combination of
$*instead of just*or$. In that process I also found out that the last capture group didn't do anything because a "hack" was used where it checked if the last character was $ or *. This was removed.For the fields, a similar tactic of checking for the first and last characters was replaced with a RegEx similar to the first one.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features. --> Will add an issue later for documentation.developbranch