Add named composite state example to stateDiagram-v2 #5485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add renamed composite as an example of composites with spaced names.
Add explanation for naming a composite state
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5485 +/- ##
==========================================
- Coverage 5.73% 5.72% -0.01%
==========================================
Files 277 278 +1
Lines 42002 42013 +11
Branches 515 490 -25
==========================================
Hits 2407 2407
- Misses 39595 39606 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@cbugk, Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Although this can be deduced from naming a state, performing it in a one-liner should not be assumed. So having an explicit example is better IMO.
Resolves #5474
📏 Design Decisions
Just defined a named state, and then populated it, alongside the first example of composites. This is not propagated to following examples though.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch