Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong ELK detector #5579

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Conversation

nirname
Copy link
Contributor

@nirname nirname commented Jun 19, 2024

📑 Summary

Brief description about the content of your PR.

Resolves #5507

📏 Design Decisions

We have to check only the beginning of the line so we need grouping.
This

/^\s*flowchar|graph/.test("some graph")

was returning true, but it should not.

📋 Tasks

Make sure you

@nirname nirname requested a review from sidharthv96 June 19, 2024 19:37
@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Jun 19, 2024
Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 66cd0b9
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6673375b7c907f0008b91bfe
😎 Deploy Preview https://deploy-preview-5579--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 5.73%. Comparing base (0044aa3) to head (66cd0b9).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5579   +/-   ##
=======================================
  Coverage     5.73%   5.73%           
=======================================
  Files          277     277           
  Lines        41988   41988           
  Branches       515     515           
=======================================
  Hits          2409    2409           
  Misses       39579   39579           
Flag Coverage Δ
unit 5.73% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid-flowchart-elk/src/detector.ts 0.00% <0.00%> (ø)

@sidharthv96 sidharthv96 added this pull request to the merge queue Jun 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2024
@varon
Copy link

varon commented Jun 20, 2024

Thanks for the fix - code LGTM.

@sidharthv96 sidharthv96 added this pull request to the merge queue Jun 20, 2024
Merged via the queue into develop with commit df72feb Jun 20, 2024
29 checks passed
@sidharthv96 sidharthv96 deleted the bug/5507_fixed-wrong-elk-detector branch June 20, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Graph' keyword in mindmap diagram breaks if elk renderer set for flowchart
3 participants