-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TreeView Diagram #5665
base: develop
Are you sure you want to change the base?
Add TreeView Diagram #5665
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @Vikrantpalle !!
Just some convention issues, and the langium change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful!!
All we need is some documentation and tests.
Existing tests can be found in cypress/integration/rendering
Documentation needs to be added in packages/mermaid/src/docs/syntax
@Vikrantpalle looks great to me! I'd say this PR is feature complete. 🚀 But treeView is a bit generic name to use for this diagram, as there are other issues/requests which could also be named a treeView. What are your thoughts on renaming this to something more specific? |
Maybe |
I feel like |
I think |
I would suggest TreeList. Because this is the purpose of it. |
I'm also leaning towards "Hierarchical Tree" is a tautology because "tree" already implies a hierarchical structure. So either The only issue I'm thinking is, if someone tries to write a file system diagram, they might not know what a |
I think documentation and examples is the way to go too. I think the only other way to solve the problem is explicitly mention Since both |
Throwing out an idea name, what about |
Hey quick comment on the langium file I saw that you were pasting the code from the common.langium into your file as opposed to importing it. If this is because it does not parse the |
I actually didn’t import the common file as whitespace is a hidden terminal in the common file, but is necessary to track indentation for the syntax. |
That makes sense. I feel like maybe the common should be separated out a bit. So if you import |
So exciting to see this nearing completion! Is there anything remaining? I'd love to use it 😉 |
📑 Summary
This PR introduces a new diagram named TreeView which displays hierarchical directory-like structures.
Resolves #2645
📷 Example
💻 Code
📏 Design Decisions
The features of the diagram focus on user flexibility and ease of use.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch