Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2853 gantt today #5717

Closed
wants to merge 1 commit into from

Conversation

bprb
Copy link

@bprb bprb commented Aug 16, 2024

📑 Summary

Add 'today' support in Gantt charts as per request 2853.

Resolves #2853

📏 Design Decisions

When the today keyword is present, its value overrides the default new Date() which is always "now". The value can be either a date in the Gantt's date format, or a duration.

📋 Tasks

Make sure you

@github-actions github-actions bot added the Type: Enhancement New feature or request label Aug 16, 2024
Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 8f2c395
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/670e39cd11abb600093f6416
😎 Deploy Preview https://deploy-preview-5717--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

argos-ci bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 2 added Oct 15, 2024, 9:54 AM

@bprb
Copy link
Author

bprb commented Aug 19, 2024

What would be the next step to get this merged? Any thoughts? Thanks in advance!

Scanning some of the 47 argos changes, they look like subpixel differences, but the rendered image is still substantially the same. Still, if I did in fact break it, please let me know.
Edit: resolved after a rebase.

@bprb bprb force-pushed the feature/2853_gantt-today branch from 72192fe to be28003 Compare August 22, 2024 22:00
Copy link

changeset-bot bot commented Aug 22, 2024

⚠️ No Changeset found

Latest commit: 8f2c395

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 26.66667% with 22 lines in your changes missing coverage. Please review.

Project coverage is 4.65%. Comparing base (742531a) to head (8f2c395).

Files with missing lines Patch % Lines
...ckages/mermaid/src/diagrams/gantt/ganttRenderer.js 0.00% 18 Missing ⚠️
packages/mermaid/src/diagrams/gantt/ganttDb.js 66.66% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5717      +/-   ##
==========================================
+ Coverage     4.64%   4.65%   +0.01%     
==========================================
  Files          375     374       -1     
  Lines        51976   51994      +18     
  Branches       587     613      +26     
==========================================
+ Hits          2414    2422       +8     
- Misses       49562   49572      +10     
Flag Coverage Δ
unit 4.65% <26.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/diagrams/gantt/ganttDb.js 77.32% <66.66%> (-0.16%) ⬇️
...ckages/mermaid/src/diagrams/gantt/ganttRenderer.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@bprb
Copy link
Author

bprb commented Aug 22, 2024

I was hoping the 2 new argos tests would create code coverage for ganttRenderer.js 🤔

@bprb bprb force-pushed the feature/2853_gantt-today branch from ec196cc to 547f61a Compare August 24, 2024 23:46
@bprb bprb force-pushed the feature/2853_gantt-today branch from 547f61a to dc1a50d Compare September 11, 2024 23:55
Copy link

pkg-pr-new bot commented Sep 11, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid@5717
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@5717
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@5717
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@5717

commit: 8f2c395

@expatiating
Copy link

If you are looking for an interim solution: #2853 (comment)

@bprb bprb force-pushed the feature/2853_gantt-today branch from dc1a50d to 8f2c395 Compare October 15, 2024 09:45
@bprb
Copy link
Author

bprb commented Oct 15, 2024

No traction, closing.

@bprb bprb closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new param today to specify the "data date"
2 participants