Skip to content

Commit

Permalink
chore: fix pre-release workflow (letsql#257)
Browse files Browse the repository at this point in the history
What?
The workflow was failing at the build stage for the Linux arch aarch64

Why?
The reason was the new Cargo dependencies for reading a csv from http(s)/s3.
In particular the ring transitive dependency: https://crates.io/crates/ring

Solution:
The solution is to drop the architectures armv7, s390x, and ppc64le, which are not supported by Datafusion or Polars.

Switch the manylinux to `2_28` when the architecture is aarch64 as suggested by:

briansmith/ring#1728 (comment)

This change was also implemented by Datafusion

https://github.com/apache/datafusion-python/blob/fe0738a9c0b536cdf20b0dc0455d14a0d16d2835/.github/workflows/build.yml#L218-L219
  • Loading branch information
mesejo authored Sep 5, 2024
1 parent 194c212 commit f5d1ec6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci-pre-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
target: [x86_64, x86, aarch64, armv7, s390x, ppc64le]
target: [x86_64, x86, aarch64]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
Expand All @@ -35,7 +35,7 @@ jobs:
target: ${{ matrix.target }}
args: --release --out dist --find-interpreter
sccache: 'true'
manylinux: auto
manylinux: ${{ matrix.target == 'aarch64' && '2_28' || 'auto' }}
- name: Upload wheels
uses: actions/upload-artifact@v4
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
target: [x86_64, x86, aarch64, armv7, s390x, ppc64le]
target: [x86_64, x86, aarch64]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
Expand All @@ -37,7 +37,7 @@ jobs:
target: ${{ matrix.target }}
args: --release --out dist --find-interpreter
sccache: 'true'
manylinux: auto
manylinux: ${{ matrix.target == 'aarch64' && '2_28' || 'auto' }}
- name: Upload wheels
uses: actions/upload-artifact@v4
with:
Expand Down

0 comments on commit f5d1ec6

Please sign in to comment.