Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix upload endpoint #97

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

theBeginner86
Copy link
Member

@theBeginner86 theBeginner86 commented Feb 9, 2025

Notes for Reviewers

Recent change in Meshery server meshery/meshery#13445 to upload mechanism caused an issue with the plugin. Due to which an empty Kanvas is observed on uploading. Eg: https://raw.githubusercontent.com/layer5labs/meshery-extensions-packages/master/action-assets/helm-plugin-assets/cfa78ee2-f1f8-4d91-ac12-5dcf0aedf0d6.png

This PR updates the endpoint to the new endpoint /api/pattern/import. Now Helm Kanvas Plugin is able to successfully visualize https://raw.githubusercontent.com/layer5labs/meshery-extensions-packages/master/action-assets/helm-plugin-assets/c6370c80-3e32-4399-bdfb-78044f6c687e.png

This PR fixes #

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Pranav Singh <[email protected]>
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (092eb01) to head (3f4052a).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
cmd/kanvas-snapshot/cmd.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master     #97   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           4       4           
  Lines         214     212    -2     
======================================
+ Misses        214     212    -2     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theBeginner86 theBeginner86 added the kind/chore Necessary task label Feb 9, 2025
@theBeginner86 theBeginner86 merged commit c5bf2fc into meshery:master Feb 9, 2025
12 checks passed
@theBeginner86
Copy link
Member Author

cc @aabidsofi19

@leecalcote
Copy link
Member

😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Necessary task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants