-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added trademark in footer #1736
Conversation
Signed-off-by: Prati28 <[email protected]>
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Revert formatting and prettier changes, if you would. @psankhe28 |
@psankhe28 Let's discuss this on Websites's call. |
Signed-off-by: Prati28 <[email protected]>
Signed-off-by: Prati28 <[email protected]>
Signed-off-by: Prati28 <[email protected]>
Hey, Pratiksha. I've taken a look at the deployment. I think that just having the word 'Trademarks' there seems a little vague. Is it possible to have something like what is implemented here as this has been confirmed to be the desired result by the issue raiser? |
In the Slack channel, I inquired about which implementation to pursue, and based on the suggestions, I was advised to implement the one you can observe in the pull request. |
But it seems too vague. It says 'Trademarks' but doesn't specify for which solution, or that it is a disclaimer either. It just links people to the LFX usage page. I don't know that this is a better outcome than the one sampled in the initial issue. If it's possible, I'll also like to see the link to the conversation that you had on slack so that I can get a bit more insight on the conversation had. |
https://layer5io.slack.com/archives/C015QJKUMPU/p1714659786470789 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@Rexford74 @psankhe28 Do we have any updates here? 👀 |
I wonder do we require this trademark? |
I don't think we need this @sudhanshutech |
lets close this pr for now also Pratiksha is not responding so we will plan over it later. Thank you folks. |
Description
This PR fixes #1622
Notes for Reviewers
Signed commits