Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only 9 cards are visible at a time #1920

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bhushan354
Copy link

@bhushan354 bhushan354 commented Oct 7, 2024

Description

This PR fixes #1852

Notes for Reviewers
Earlier, all the cards were displayed at once in meshery.io/catalog page, This MR contains changes which shows only 9 cards per page.

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 368eacc
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/67039c02dabae100087301f7
😎 Deploy Preview https://deploy-preview-1920--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Bhushan Deshmukh <[email protected]>
@vishalvivekm
Copy link
Member

@bhushan354
Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

adding it as an agenda item to the meeting minutes.

Copy link
Contributor

@jamieplu jamieplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping in.

Have you verified the performance of this change. How does it behave?

@bhushan354
Copy link
Author

I have reverted the changes I have made earlier now trying to fix the exact bug

@jameshorton2337
Copy link
Contributor

What's the bug?

@vishalvivekm
Copy link
Member

@bhushan354 would we be discussing updates from you on this PR today?

Note

Weekly websites call : https://meet.layer5.io/websites
Oct 14, 2024 at 7 AM CT | 5:30 PM IST
Meeting minutes: https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit?tab=t.0

@vishalvivekm vishalvivekm added issue/invalid This doesn't seem right pr/do-not-merge PRs not ready to be merged labels Oct 14, 2024
@bhushan354
Copy link
Author

@vishalvivekm , I was unable to find the bug, but I’m still working on it. Also, I wanted to ask why the changes I made to the code, like the UI updates, aren't reflecting on localhost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/website issue/invalid This doesn't seem right pr/do-not-merge PRs not ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All items displayed on page load
4 participants