[UI] fixed extension page #2089
Conversation
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. |
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Aditya Raj <[email protected]> updated Signed-off-by: Aditya Raj <[email protected]>
There was a problem hiding this comment.
Hi, @Dungeon-Masterji I think there is .import-secondar{} elements is already there in catalog.scss, you again wrote it in different file, you did not utilised the code reusability property, My suggestion would be to follow the same design pattern that is already there, like
you can use this below pattern:
.root{
some_name: black;
}
.dark-mode{
some_name: white;
}then you can use this "some_name" variable in the .import-secondary{} element like this:
.import-secondary{
color: var(some_name);
}Above solution also toggle the "Learn more" text color to white when dark mode is enabled and text color will be black when dark mode is disabled
this is more efficient and enhance code readability, reusability. But if @sudhanshutech,@Karan-Palan approve this then this is good to go.
|
@Dungeon-Masterji adding it as an agenda item to the meeting minutes. |
Description
This PR resolves the issue where:
The text above extension cards was not visible in light mode.
The text on the "Learn More" button was not visible in light mode.
Solution
Enhanced the CSS to ensure proper text visibility in both light and dark modes, improving overall accessibility and user experience.
Expected Behavior
The text remains clearly visible in both light and dark modes.
UI consistency is maintained across themes.
Let me know if any further adjustments are needed. 🚀
This PR fixes #2084
here are the images for reviews
Notes for Reviewers
Signed commits