Merge pull request #175 from jbyers19/logger-fix

fixed logger types
meshery · Apr 23, 2022 · 023d12e · 023d12e
2 parents c51f0c0 + 85792ff
commit 023d12e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/logger/controller.go b/logger/controller.go
@@ -19,11 +19,12 @@ type Controller struct {
 	base    *Logger
 }
 
-func (l *Logger) ControllerLogger() logr.LogSink {
-	return &Controller{
+func (l *Logger) ControllerLogger() logr.Logger {
+	c := &Controller{
 		enabled: true,
 		base:    l,
 	}
+	return logr.New(c)
 }
 
 func (c *Controller) Init(info logr.RuntimeInfo) {}

diff --git a/logger/logger.go b/logger/logger.go
@@ -17,7 +17,7 @@ type Handler interface {
 	Error(err error)
 
 	// Kubernetes Controller compliant logger
-	ControllerLogger() logr.LogSink
+	ControllerLogger() logr.Logger
 	DatabaseLogger() gormlogger.Interface
 }