Skip to content

Commit

Permalink
Merge pull request #474 from Aijeyomah/aijeyomah/chore/default-model-…
Browse files Browse the repository at this point in the history
…filter-sort-order

chore: Set 'display_name' as the default ordering column for model filter
  • Loading branch information
leecalcote authored Mar 12, 2024
2 parents 3289f21 + 7483ddc commit 75d94b9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ newIssueWelcomeComment: >
newPRWelcomeComment: >
Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the [Layer5 Community Welcome Guide](https://docs.google.com/document/d/17OPtDE_rdnPQxmk2Kauhm3GwXF1R5dZ3Cj8qZLKdo5E/edit?usp=sharing) and sure to join the [community Slack](http://slack.layer5.io/).
Be sure to double-check that you have signed your commits. Here are instructions for [making signing an implicit activity while peforming a commit](../CONTRIBUTING.md#signing-off-on-commits-developer-certificate-of-origin).
Be sure to double-check that you have signed your commits. Here are instructions for [making signing an implicit activity while peforming a commit](https://github.com/meshery/meshkit/blob/master/CONTRIBUTING.md#general-contribution-flow).
#-------------------------------------------------------------------------------
Expand Down
2 changes: 2 additions & 0 deletions models/meshmodel/registry/registry.go
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,8 @@ func (rm *RegistryManager) GetModels(db *database.Handler, f types.Filter) ([]v1
} else {
finder = finder.Order(mf.OrderOn)
}
} else {
finder = finder.Order("display_name")
}

finder.Count(&count)
Expand Down

0 comments on commit 75d94b9

Please sign in to comment.