Skip to content

Commit

Permalink
Small fix: Correctly pass secrets in Docker builds (#5905)
Browse files Browse the repository at this point in the history
  • Loading branch information
vidplace7 authored Jan 22, 2025
1 parent 71591fb commit 0fdbf70
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/docker_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ name: Build Docker

on:
workflow_call:
secrets:
DOCKER_FIRMWARE_TOKEN:
required: false # Only required for push
inputs:
distro:
description: Distro to target
Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/docker_manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ name: Build Docker Multi-Arch Manifest

on:
workflow_call:
secrets:
DOCKER_FIRMWARE_TOKEN:
required: true
inputs:
release_channel:
description: Release channel to target
Expand All @@ -20,6 +23,7 @@ jobs:
platform: linux/amd64
runs-on: ubuntu-24.04
push: true
secrets: inherit

docker-debian-arm64:
uses: ./.github/workflows/docker_build.yml
Expand All @@ -28,6 +32,7 @@ jobs:
platform: linux/arm64
runs-on: ubuntu-24.04-arm
push: true
secrets: inherit

docker-debian-armv7:
uses: ./.github/workflows/docker_build.yml
Expand All @@ -36,6 +41,7 @@ jobs:
platform: linux/arm/v7
runs-on: ubuntu-24.04-arm
push: true
secrets: inherit

docker-alpine-amd64:
uses: ./.github/workflows/docker_build.yml
Expand All @@ -44,6 +50,7 @@ jobs:
platform: linux/amd64
runs-on: ubuntu-24.04
push: true
secrets: inherit

docker-alpine-arm64:
uses: ./.github/workflows/docker_build.yml
Expand All @@ -52,6 +59,7 @@ jobs:
platform: linux/arm64
runs-on: ubuntu-24.04-arm
push: true
secrets: inherit

docker-alpine-armv7:
uses: ./.github/workflows/docker_build.yml
Expand All @@ -60,6 +68,7 @@ jobs:
platform: linux/arm/v7
runs-on: ubuntu-24.04-arm
push: true
secrets: inherit

docker-manifest:
needs:
Expand Down

0 comments on commit 0fdbf70

Please sign in to comment.