Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support manual Protobuf update process #4823

Conversation

scruplelesswizard
Copy link
Contributor

This re-enables the update process originally used for protobufs, lost in #4805

@scruplelesswizard scruplelesswizard force-pushed the preserve-protobuf-update-process branch from 520c7c8 to dd31341 Compare September 22, 2024 16:08
@scruplelesswizard
Copy link
Contributor Author

scruplelesswizard commented Sep 22, 2024

The workflow from #4805 did not trigger when tested in in #4818.
Github Actions doesn't appear to traverse the submodule, making the paths filter on protobufs/ effectively never().

This PR also updates the paths filter to .gitmodules. This has the side-effect that the workflow will trigger every time the meshtestic submodule is updated as well. This may cause the EndBug/add-and-commit when there are no files to add, the documentation appears inconsitent on the behavior.

@scruplelesswizard scruplelesswizard marked this pull request as draft September 22, 2024 18:24
@github-actions github-actions bot added the Stale label Jan 2, 2025
@github-actions github-actions bot closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants