Adding XIAO ESP32C6 with BLE support #5421
Conversation
bin/version_script.py
Outdated
There was a problem hiding this comment.
Ths is a part of platformio-custom.py - is this needed by cmake?
There was a problem hiding this comment.
For some reason, the call to platformio-custom.py and the following part:
# General options that are passed to the C and C++ compilers
projenv.Append(
CCFLAGS=[
"-DAPP_VERSION=" + verObj["long"],
"-DAPP_VERSION_SHORT=" + verObj["short"],
"-DAPP_ENV=" + env.get("PIOENV"),
]
)has no effect.
I tried adding the following lines to the end of platformio-custom.py:
env.Append(
BUILD_FLAGS=[
"-DAPP_VERSION=" + verObj["long"],
"-DAPP_VERSION_SHORT=" + verObj["short"],
"-DAPP_ENV=" + env.get("PIOENV"),
]
)but it didn't work either.
What eventually worked was adding this line with the pre instruction:
extra_scripts = pre:bin/version_script.pyIt seems that ESP-IDF adds its own CMakeLists.txt to the root of the project during compilation, which might cause the root platformio.ini to become disconnected.
Maybe another pair of eyes can help here. 🙂
There was a problem hiding this comment.
No problem, i just hate duplicate code. i am not python savvy but maybe we can 'include' the new file in the existing one, replacing that part?
There was a problem hiding this comment.
Agree. I'll refactor this.
Just for the reference I'll leave it here:
|
I am testing a few corner cases with this. Especially with the other C6 board (TLora C6) we have. Is it ok to push minor corrections to your branch? |
Sure, I am fine with that! |
|
@caveman99 just FYI, I'm fixing the failed builds for other targets... 🤷 |
…e into xiao_esp32c6_with_ble
Bluetooth functionality is working again 🎉
|
Hi @caveman99 , I think we're good to go now. Could you take a look please? |
alexbegoon
changed the title
Related to #4692
The main purpose of this PR is to enhance the ESP32-C6 target by integrating BLE functionality